copy_object: support passing another request options #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: passing `destination_predefined_acl`
|
Ah, thank you so much! Esp. for including tests ^__^ I'll merge once integration tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 88.49% 88.46% -0.04%
==========================================
Files 311 311
Lines 5217 5217
==========================================
- Hits 4617 4615 -2
- Misses 600 602 +2
Continue to review full report at Codecov.
|
|
@yosiat Do you want me to release the changes right away? |
|
@Temikus if that's possible it will be awesome! since I need to do another PR in carrierwave. |
|
@yosiat done! |
mshibuya
added a commit
to mshibuya/fog-google
that referenced
this pull request
Mar 14, 2021
cheungpat
pushed a commit
to cheungpat/fog-google
that referenced
this pull request
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example: passing
destination_predefined_aclhandles: #505 and #499 (comment)